Messages in this thread Patch in this message | | | Date | Tue, 20 Mar 2007 13:32:45 +0100 | From | Pavel Machek <> | Subject | "reboot" swsusp mode leaves moon icon blinking |
| |
Hi!
...and cause is really simple.
During resume, we do not know that "reboot" method was used, so we assume plaform and make the led blink...
Unfortunately I see no easy solution, and this may/will cause other problems -- in case of broken bios and user telling us not to call that bios, we'll call it anyway.
(Ouch and I think this is regression after 2.6.20?)
Signed-off-by: Pavel Machek <pavel@suse.cz>
Pavel
diff --git a/kernel/power/disk.c b/kernel/power/disk.c index 873cdf8..dee0ff4 100644 --- a/kernel/power/disk.c +++ b/kernel/power/disk.c @@ -241,18 +241,11 @@ static int software_resume(void) goto Done; } - error = platform_prepare(); - if (error) { - swsusp_free(); - goto Thaw; - } - pr_debug("PM: Reading swsusp image.\n"); error = swsusp_read(); if (error) { swsusp_free(); - platform_finish(); goto Thaw; } @@ -270,7 +263,6 @@ static int software_resume(void) enable_nonboot_cpus(); Free: swsusp_free(); - platform_finish(); device_resume(); resume_console(); Thaw: -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |