lkml.org 
[lkml]   [2007]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: "reboot" swsusp mode leaves moon icon blinking
    Date
    On Tuesday, 20 March 2007 17:50, Johannes Weiner wrote:
    > Hi,
    >
    > On Tue, Mar 20, 2007 at 01:32:45PM +0100, Pavel Machek wrote:
    > > Date: Tue, 20 Mar 2007 13:32:45 +0100
    > > From: Pavel Machek <pavel@ucw.cz>
    > > To: "Rafael J. Wysocki" <rjw@sisk.pl>,
    > > kernel list <linux-kernel@vger.kernel.org>
    > > Cc: Andrew Morton <akpm@osdl.org>
    > > Subject: "reboot" swsusp mode leaves moon icon blinking
    > >
    > > Hi!
    > >
    > > ...and cause is really simple.
    > >
    > > During resume, we do not know that "reboot" method was used, so we
    > > assume plaform and make the led blink...
    >
    > What does the "reboot" swsusp mean?
    >
    > I am having this (or a similar problem):
    >
    > echo shutdown > /sys/power/disk; echo disk > /sys/power/state
    >
    > suspends normally. But after a resume, the moon keeps blinking _and_
    > I don't get ACPI events anymore. At least all ibm-acpi features refuse
    > to work (hotkeys, lcd-brightness, lid, ...).
    >
    > I saved some /proc files (interrupts, acpi/processor/power, ...) and
    > compared them before the suspend and after the resume but I could not
    > find any differences.
    >
    > > diff --git a/kernel/power/disk.c b/kernel/power/disk.c
    > > index 873cdf8..dee0ff4 100644
    > > --- a/kernel/power/disk.c
    > > +++ b/kernel/power/disk.c
    > > @@ -241,18 +241,11 @@ static int software_resume(void)
    > > goto Done;
    > > }
    > >
    > > - error = platform_prepare();
    > > - if (error) {
    > > - swsusp_free();
    > > - goto Thaw;
    > > - }
    > > -
    >
    > What is platform_prepare() actually good for when _resuming_? I tried to
    > follow the function calls and it seems to disable a lot of thing instead
    > of re-enabling them...?

    Well, if you suspend using the platform mode, platform_finish() will be called
    after the image has been restored (ie. by the "old" kernel).

    Greetings,
    Rafael


    --
    If you don't have the time to read,
    you don't have the time or the tools to write.
    - Stephen King
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-20 17:59    [W:3.277 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site