Messages in this thread | | | Date | Tue, 20 Mar 2007 18:20:23 +0100 | From | Pavel Machek <> | Subject | Re: "reboot" swsusp mode leaves moon icon blinking |
| |
Hi!
> > ...and cause is really simple. > > > > During resume, we do not know that "reboot" method was used, so we > > assume plaform and make the led blink... > > > > Unfortunately I see no easy solution, and this may/will cause other > > problems -- in case of broken bios and user telling us not to call > > that bios, we'll call it anyway. > > > > (Ouch and I think this is regression after 2.6.20?) > > I'm not sure, will check that later. > > The solution would be to pass the information about the suspend mode used > in the image header, I think (that's what uswsusp does after my recent patch).
Yes, we could do that.
OTOH, we could simply avoid calling the platform code in resume path. It worked ok for a long while, and it seems to have no downsides...
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |