Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: "reboot" swsusp mode leaves moon icon blinking | Date | Tue, 20 Mar 2007 22:03:26 +0100 |
| |
On Tuesday, 20 March 2007 18:20, Pavel Machek wrote: > Hi! > > > > ...and cause is really simple. > > > > > > During resume, we do not know that "reboot" method was used, so we > > > assume plaform and make the led blink... > > > > > > Unfortunately I see no easy solution, and this may/will cause other > > > problems -- in case of broken bios and user telling us not to call > > > that bios, we'll call it anyway. > > > > > > (Ouch and I think this is regression after 2.6.20?) > > > > I'm not sure, will check that later. > > > > The solution would be to pass the information about the suspend mode used > > in the image header, I think (that's what uswsusp does after my recent patch). > > Yes, we could do that. > > OTOH, we could simply avoid calling the platform code in resume > path. It worked ok for a long while, and it seems to have no > downsides...
No, we have always done it, actually, but not in this particular place. ;-)
In theory, avoiding it could be problematic, because of the pm_ops->finish() that gets called after the image has been restored (if the platform mode was used for suspending). Still, I think we can try.
Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |