| Date | Wed, 27 Mar 2024 10:38:59 -0700 | Subject | Re: [PATCH 11/26] cxl/pci: Delay event buffer allocation | From | Dave Jiang <> |
| |
On 3/24/24 4:18 PM, Ira Weiny wrote: > The event buffer does not need to be allocated if something has failed > in setting up event irq's. > > In prep for adjusting event configuration for DCD events move the buffer > allocation to the end of the event configuration. > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c > index cedd9b05f129..ccaf4ad26a4f 100644 > --- a/drivers/cxl/pci.c > +++ b/drivers/cxl/pci.c > @@ -756,10 +756,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, > return 0; > } > > - rc = cxl_mem_alloc_event_buf(mds); > - if (rc) > - return rc; > - > rc = cxl_event_get_int_policy(mds, &policy); > if (rc) > return rc; > @@ -777,6 +773,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, > if (rc) > return rc; > > + rc = cxl_mem_alloc_event_buf(mds); > + if (rc) > + return rc; > + > rc = cxl_event_irqsetup(mds, &policy); > if (rc) > return rc; >
|