Messages in this thread | | | Date | Tue, 9 Apr 2024 21:48:45 -0700 | From | Ira Weiny <> | Subject | Re: [PATCH 13/26] cxl/mem: Configure dynamic capacity interrupts |
| |
fan wrote: > On Sun, Mar 24, 2024 at 04:18:16PM -0700, ira.weiny@intel.com wrote: > > From: Navneet Singh <navneet.singh@intel.com>
[snip]
> > @@ -786,12 +830,15 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, > > if (rc) > > return rc; > > > > - rc = cxl_event_irqsetup(mds, &policy); > > + rc = cxl_irqsetup(mds, &policy, native_cxl); > > if (rc) > > return rc; > > > > cxl_mem_get_event_records(mds, CXLDEV_EVENT_STATUS_ALL); > > > > + dev_dbg(mds->cxlds.dev, "Event config : %d %d\n", > > + native_cxl, cxl_dcd_supported(mds)); > > The message will print out two numbers, seems not very clear. Should we > translate to more straightforward message, like > native_cxl? "OS...":"" > cxl_dcd_supported(msd)? "DCD supported": "DCD not supported"?
Perhaps but it is just a debug message to know if something is wonky with a BIOS configuration.
So I'm inclined to leave it alone. Ira
| |