Messages in this thread | | | Date | Tue, 9 Apr 2024 22:34:08 -0700 | From | Ira Weiny <> | Subject | Re: [PATCH 13/26] cxl/mem: Configure dynamic capacity interrupts |
| |
Jonathan Cameron wrote: > On Sun, 24 Mar 2024 16:18:16 -0700 > ira.weiny@intel.com wrote: > > > From: Navneet Singh <navneet.singh@intel.com> > > > > Dynamic Capacity Devices (DCD) support extent change notifications > > through the event log mechanism. The interrupt mailbox commands were > > extended in CXL 3.1 to support these notifications. > > > > Firmware can't configure DCD events to be FW controlled but can retain > > control of memory events. Split irq configuration of memory events and > > DCD events to allow for FW control of memory events while DCD is host > > controlled. > > > > Configure DCD event log interrupts on devices supporting dynamic > > capacity. Disable DCD if interrupts are not supported. > > > > Signed-off-by: Navneet Singh <navneet.singh@intel.com> > > Co-developed-by: Ira Weiny <ira.weiny@intel.com> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > Trivial comment inline and Fan's suggestion on the debug print seems sensible > to me.
Ok I went ahead and added it.
> Either way > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Thanks, Ira
| |