lkml.org 
[lkml]   [2023]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH net-next 5/6] microchip: lan865x: add driver support for Microchip's LAN865X MACPHY
Date
Hi Andrew,

On 14/09/23 7:25 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +#define REG_STDR_RESET 0x00000003
>
> This appears to be a standard register, so you should not need to
> define it here.
Ah ok, will do it.
>
>> +#define REG_MAC_ADDR_BO 0x00010022
>> +#define REG_MAC_ADDR_L 0x00010024
>> +#define REG_MAC_ADDR_H 0x00010025
>> +#define REG_MAC_NW_CTRL 0x00010000
>> +#define REG_MAC_NW_CONFIG 0x00010001
>> +#define REG_MAC_HASHL 0x00010020
>> +#define REG_MAC_HASHH 0x00010021
>> +#define REG_MAC_ADDR_BO 0x00010022
>> +#define REG_MAC_ADDR_L 0x00010024
>> +#define REG_MAC_ADDR_H 0x00010025
>> +
>> +#define CCS_Q0_TX_CFG 0x000A0081
>> +#define CCS_Q0_RX_CFG 0x000A0082
>
> These are proprietary vendor registers, so please add a prefix to make
> this clear.
Sure, will add it in the next version.

Best Regards,
Parthiban V
>
> Andrew

\
 
 \ /
  Last update: 2023-09-18 13:30    [W:0.353 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site