lkml.org 
[lkml]   [2023]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface
Date
Hi Andrew,

On 13/09/23 7:46 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +struct oa_tc6 {
>> + struct spi_device *spi;
>> + bool ctrl_prot;
>> +};
>
> Should this be considered an opaque structure which the MAC driver
> should not access the members?
>
> I don't see anything setting ctrl_prot here. Does it need a setter and
> a getter?
Ah ok, it is supposed to be done in the oa_tc6_init() function. Somehow
missed it. Will correct it in the next version.

Best Regards,
Parthiban V
>
> Andrew

\
 
 \ /
  Last update: 2023-09-19 13:22    [W:0.125 / U:4.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site