Messages in this thread | | | From | <> | Subject | Re: [RFC PATCH net-next 4/6] net: ethernet: implement data transaction interface | Date | Tue, 19 Sep 2023 10:12:55 +0000 |
| |
Hi Andrew,
On 18/09/23 6:31 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>>> +#define MAX_ETH_LEN 1536 >>> >>> Where do 1536 come from? Maybe this needs an OA_TC6 prefix to make it >>> clear this is specific to this protocol? >> Ah it is a mistake. It is supposed to be an ethernet packet size which >> is 1518 (1500 bytes MTU size + 18 bytes overhead) and it is not from OA. >> It is a mistake and will correct it in the next version. > > Please try to express this using ETH_DATA_LEN + sizeof(struct > oa_tc6_overhead). Doing it like this will avoid errors like this since > it is also part documentation. Ok, in my case the define would be,
#define MAX_ETH_LEN (ETH_DATA_LEN + ETH_HLEN + ETH_FCS_LEN)
Best Regards, Parthiban V
> > Andrew
| |