| Date | Fri, 28 Jul 2023 17:02:30 -0700 | Subject | Re: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology() | From | Sohil Mehta <> |
| |
On 7/28/2023 5:13 AM, Thomas Gleixner wrote: > Topology evaluation is a complete disaster and impenetrable mess. It's > scattered all over the place with some vendor implementatins doing early
s/implementatins/implementations
> +static void parse_topology(struct topo_scan *tscan, bool early) > +{ > + const struct cpuinfo_topology topo_defaults = { > + .cu_id = 0xff, > + .llc_id = BAD_APICID, > + .l2c_id = BAD_APICID, > + }; > + struct cpuinfo_x86 *c = tscan->c; > + struct { > + u32 unused0 : 16, > + nproc : 8, > + apicid : 8; > + } ebx; > + > + c->topo = topo_defaults; > + > + if (fake_topology(tscan)) > + return; > +
Spaces used for indenting "return" instead of a tab.
|