Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology() | Date | Tue, 01 Aug 2023 09:34:28 +0200 |
| |
On Tue, Aug 01 2023 at 12:35, Gautham R. Shenoy wrote: > On Fri, Jul 28, 2023 at 02:13:08PM +0200, Thomas Gleixner wrote: >> +static void topo_set_ids(struct topo_scan *tscan) >> +{ >> + struct cpuinfo_x86 *c = tscan->c; >> + u32 apicid = c->topo.apicid; >> + >> + c->topo.pkg_id = topo_shift_apicid(apicid, TOPO_ROOT_DOMAIN); > > Shouldn't this use TOPO_PKG_DOMAIN instead of TOPO_ROOT_DOMAIN ?
Yup. It does not make a difference in that case. That's why I didn't notice, but let me fix this for conistency sake.
| |