lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/12] writeback: Factor should_writeback_folio() out of write_cache_pages()
> +	if (folio_test_writeback(folio)) {
> + if (wbc->sync_mode != WB_SYNC_NONE)
> + folio_wait_writeback(folio);
> + else
> + return false;
> + }

Please reorder this to avoid the else and return earlier while you're
at it:

if (folio_test_writeback(folio)) {
if (wbc->sync_mode == WB_SYNC_NONE)
return false;
folio_wait_writeback(folio);
}

(that's what actually got me started on my little cleanup spree while
checking some details of the writeback waiting..)

> + BUG_ON(folio_test_writeback(folio));
> + if (!folio_clear_dirty_for_io(folio))
> + return false;
> +
> + return true;

..

return folio_clear_dirty_for_io(folio);

?

\
 
 \ /
  Last update: 2023-06-27 06:12    [W:0.162 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site