| Date | Mon, 26 Jun 2023 21:05:18 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 01/12] writeback: Factor out writeback_finish() |
| |
On Mon, Jun 26, 2023 at 06:35:10PM +0100, Matthew Wilcox (Oracle) wrote: > + struct folio_batch fbatch; > + pgoff_t done_index; > + int err; > +
I think this really needs a comment that it should only be used for the writeback iterator. In fact this whole structure could use a lot more comments on what should / can be set by the caller, and what is internal.
> + unsigned range_whole:1; /* entire file */
Same here.
|