lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] writeback: Factor out writeback_finish()
On Mon, Jun 26, 2023 at 06:35:10PM +0100, Matthew Wilcox (Oracle) wrote:
> + struct folio_batch fbatch;
> + pgoff_t done_index;
> + int err;
> +

I think this really needs a comment that it should only be used for
the writeback iterator. In fact this whole structure could use a lot
more comments on what should / can be set by the caller, and what is
internal.

> + unsigned range_whole:1; /* entire file */

Same here.

\
 
 \ /
  Last update: 2023-06-27 06:06    [W:0.206 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site