| Date | Mon, 26 Jun 2023 21:34:17 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 08/12] writeback: Factor writeback_get_folio() out of write_cache_pages() |
| |
> + for (;;) { > + folio = writeback_get_next(mapping, wbc); > + if (!folio) > + return NULL; > + wbc->done_index = folio->index; > + > + folio_lock(folio); > + if (likely(should_writeback_folio(mapping, wbc, folio))) > + break; > + folio_unlock(folio); > + } > + > + trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); > + return folio;
Same minor nitpick, why not:
while ((folio = writeback_get_next(mapping, wbc)) { wbc->done_index = folio->index;
folio_lock(folio); if (likely(should_writeback_folio(mapping, wbc, folio))) { trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); break; } folio_unlock(folio); }
return folio;
?
|