lkml.org 
[lkml]   [2023]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages()
On Mon, Jun 26, 2023 at 09:30:07PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote:
> > + for (folio = writeback_iter_init(mapping, wbc);
> > + folio;
> > + folio = writeback_get_next(mapping, wbc)) {
>
> Ok that's another way to structure it. Guess I should look over the
> whole series first..

That beeing said. Given that writeback_iter_init calls
writeback_get_next anyway,

writeback_iter_init(mapping, wbc);
while ((folio = writeback_get_next(mapping, wbc)))

still feels a little easier to follow to be. No hard feelings either
way, just an observation.

\
 
 \ /
  Last update: 2023-06-27 06:32    [W:0.059 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site