| Date | Tue, 14 Feb 2023 09:13:08 +0100 | Subject | Re: [PATCH v2 04/24] arm64/cpu: Mark cpu_die() __noreturn | From | Philippe Mathieu-Daudé <> |
| |
On 14/2/23 08:05, Josh Poimboeuf wrote: > cpu_die() doesn't return. Annotate it as such. By extension this also > makes arch_cpu_idle_dead() noreturn. > > Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> > --- > arch/arm64/include/asm/smp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h > index fc55f5a57a06..5733a31bab08 100644 > --- a/arch/arm64/include/asm/smp.h > +++ b/arch/arm64/include/asm/smp.h > @@ -100,7 +100,7 @@ static inline void arch_send_wakeup_ipi_mask(const struct cpumask *mask) > extern int __cpu_disable(void); > > extern void __cpu_die(unsigned int cpu); > -extern void cpu_die(void); > +extern void __noreturn cpu_die(void); > extern void cpu_die_early(void);
Shouldn't cpu_operations::cpu_die() be declared noreturn first?
|