| From | Josh Poimboeuf <> | Subject | [PATCH v2 05/24] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return | Date | Mon, 13 Feb 2023 23:05:39 -0800 |
| |
arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next.
Acked-by: Guo Ren <guoren@kernel.org> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> --- arch/csky/kernel/smp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c index b45d1073307f..0ec20efaf5fd 100644 --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void) "jmpi csky_start_secondary" : : "r" (secondary_stack)); + + BUG(); } #endif -- 2.39.1
|