lkml.org 
[lkml]   [2023]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v14 20/56] media: dvb-frontends: rtl2832: Stop direct calls to queue num_buffers field
From
W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
> This allows us to change how the number of buffers is computed in the
> future.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> CC: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/dvb-frontends/rtl2832_sdr.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c
> index 02c619e51641..023db6e793f8 100644
> --- a/drivers/media/dvb-frontends/rtl2832_sdr.c
> +++ b/drivers/media/dvb-frontends/rtl2832_sdr.c
> @@ -439,12 +439,13 @@ static int rtl2832_sdr_queue_setup(struct vb2_queue *vq,
> {
> struct rtl2832_sdr_dev *dev = vb2_get_drv_priv(vq);
> struct platform_device *pdev = dev->pdev;
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
>
> dev_dbg(&pdev->dev, "nbuffers=%d\n", *nbuffers);
>
> /* Need at least 8 buffers */
> - if (vq->num_buffers + *nbuffers < 8)
> - *nbuffers = 8 - vq->num_buffers;
> + if (q_num_bufs + *nbuffers < 8)
> + *nbuffers = 8 - q_num_bufs;
> *nplanes = 1;
> sizes[0] = PAGE_ALIGN(dev->buffersize);
> dev_dbg(&pdev->dev, "nbuffers=%d sizes[0]=%d\n", *nbuffers, sizes[0]);

\
 
 \ /
  Last update: 2023-11-20 13:53    [W:0.903 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site