lkml.org 
[lkml]   [2023]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v14 22/56] media: pci: tw686x: Stop direct calls to queue num_buffers field
    From
    W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
    > Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
    > This allows us to change how the number of buffers is computed in the
    > future.
    >
    > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

    Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

    > CC: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
    > ---
    > drivers/media/pci/tw686x/tw686x-video.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
    > index 3ebf7a2c95f0..6bc6d143d18c 100644
    > --- a/drivers/media/pci/tw686x/tw686x-video.c
    > +++ b/drivers/media/pci/tw686x/tw686x-video.c
    > @@ -423,6 +423,7 @@ static int tw686x_queue_setup(struct vb2_queue *vq,
    > unsigned int sizes[], struct device *alloc_devs[])
    > {
    > struct tw686x_video_channel *vc = vb2_get_drv_priv(vq);
    > + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
    > unsigned int szimage =
    > (vc->width * vc->height * vc->format->depth) >> 3;
    >
    > @@ -430,8 +431,8 @@ static int tw686x_queue_setup(struct vb2_queue *vq,
    > * Let's request at least three buffers: two for the
    > * DMA engine and one for userspace.
    > */
    > - if (vq->num_buffers + *nbuffers < 3)
    > - *nbuffers = 3 - vq->num_buffers;
    > + if (q_num_bufs + *nbuffers < 3)
    > + *nbuffers = 3 - q_num_bufs;
    >
    > if (*nplanes) {
    > if (*nplanes != 1 || sizes[0] < szimage)

    \
     
     \ /
      Last update: 2023-11-20 13:53    [W:4.709 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site