lkml.org 
[lkml]   [2023]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v14 39/56] media: usb: airspy: Stop direct calls to queue num_buffers field
    From
    W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
    > Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
    > This allows us to change how the number of buffers is computed in the
    > future.
    >
    > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

    Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

    > ---
    > drivers/media/usb/airspy/airspy.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
    > index 462eb8423506..e24e655fb1db 100644
    > --- a/drivers/media/usb/airspy/airspy.c
    > +++ b/drivers/media/usb/airspy/airspy.c
    > @@ -482,12 +482,13 @@ static int airspy_queue_setup(struct vb2_queue *vq,
    > unsigned int *nplanes, unsigned int sizes[], struct device *alloc_devs[])
    > {
    > struct airspy *s = vb2_get_drv_priv(vq);
    > + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
    >
    > dev_dbg(s->dev, "nbuffers=%d\n", *nbuffers);
    >
    > /* Need at least 8 buffers */
    > - if (vq->num_buffers + *nbuffers < 8)
    > - *nbuffers = 8 - vq->num_buffers;
    > + if (q_num_bufs + *nbuffers < 8)
    > + *nbuffers = 8 - q_num_bufs;
    > *nplanes = 1;
    > sizes[0] = PAGE_ALIGN(s->buffersize);
    >

    \
     
     \ /
      Last update: 2023-11-20 13:54    [W:5.582 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site