| Date | Thu, 9 Nov 2023 10:50:46 +0100 | Subject | Re: [PATCH v14 19/56] media: dvb-core: Do not initialize twice queue num_buffer field | From | Andrzej Pietrasiewicz <> |
| |
Hi Benjamin,
W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze: > The above memset already zeroed all the ctx fields, it is useless > to do it here again. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > --- > drivers/media/dvb-core/dvb_vb2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c > index 3a966fdf814c..a731b755a0b9 100644 > --- a/drivers/media/dvb-core/dvb_vb2.c > +++ b/drivers/media/dvb-core/dvb_vb2.c > @@ -177,7 +177,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking) > q->ops = &dvb_vb2_qops; > q->mem_ops = &vb2_vmalloc_memops; > q->buf_ops = &dvb_vb2_buf_ops; > - q->num_buffers = 0;
A few lines above this one is this:
q->is_output = 0;
Can this also be included in this (cleanup) patch?
Regards,
Andrzej
> ret = vb2_core_queue_init(q); > if (ret) { > ctx->state = DVB_VB2_STATE_NONE;
|