| Date | Thu, 30 Nov 2023 17:35:12 +0000 | From | Simon Horman <> | Subject | Re: [PATCH 13/13] net: ravb: Add runtime PM support |
| |
On Mon, Nov 20, 2023 at 10:46:06AM +0200, Claudiu wrote:
...
> } > } > > + error = ravb_pm_runtime_get(priv); > + if (error < 0) > + return error;
Hi Claudiu,
the error handling doesn't seem right here. I think you need:
goto out_free_irq_mgmta;
> + > /* Device init */ > error = ravb_dmac_init(ndev); > if (error) > - goto out_free_irq_mgmta; > + goto pm_runtime_put; > ravb_emac_init(ndev); > > /* Initialise PTP Clock driver */ > @@ -1820,7 +1862,8 @@ static int ravb_open(struct net_device *ndev) > if (info->gptp) > ravb_ptp_stop(ndev); > ravb_stop_dma(ndev); > -out_free_irq_mgmta: > +pm_runtime_put: > + ravb_pm_runtime_put(priv);
And the out_free_irq_mgmta label should go here.
Flagged by Smatch.
> if (!info->multi_irqs) > goto out_free_irq; > if (info->err_mgmt_irqs)
...
|