Messages in this thread | | | Subject | Re: [PATCH 02/13] net: ravb: Use pm_runtime_resume_and_get() | From | Sergey Shtylyov <> | Date | Mon, 20 Nov 2023 22:23:57 +0300 |
| |
On 11/20/23 11:45 AM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > pm_runtime_get_sync() may return with error. In case it returns with error > dev->power.usage_count needs to be decremented. pm_runtime_resume_and_get() > takes care of this. Thus use it. > > Along with this pm_runtime_resume_and_get() and reset_control_deassert() > were moved before alloc_etherdev_mqs() to simplify the error path.
I don't see how it simplifies the error path... Re-ordering the statements at the end of the error path seems cheaper than what you do.
> Also, in case pm_runtime_resume_and_get() returns error the reset signal > is deasserted and runtime PM is disabled (by jumping to the proper > error handling label). > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> [...]
MBR, Sergey
| |