Messages in this thread | | | Subject | Re: [PATCH 12/13] net: ravb: Assert/deassert reset on suspend/resume | From | Sergey Shtylyov <> | Date | Tue, 21 Nov 2023 22:13:52 +0300 |
| |
On 11/20/23 11:46 AM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > RZ/G3S can go to deep sleep states where power to most of the SoC parts > is off. When resumming from such state the Ethernet controller needs to be
Resuming.
> reinitialized. Deasserting the reset signal for it should also be done. > Thus add reset assert/deassert on suspend/resume functions.
Firefox' spell checker trips over deassert[ing] and you have |de-assert" below:
> On resume function the de-assert was not reverted in case of failures to > give user a chance to restore the interface (e.g. bringing down/up the > interface) in case suspend/resume fails.
I'm not seeing us reverting anything on the resume failure...
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
| |