Messages in this thread | | | Subject | Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert() | From | Sergey Shtylyov <> | Date | Mon, 27 Nov 2023 19:39:52 +0300 |
| |
On 11/27/23 12:04 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > reset_control_deassert() could return an error. Some devices cannot work > if reset signal de-assert operation fails.
Well, I think all devices can't work if the reset line is connected at all. :-)
> To avoid this check the return > code of reset_control_deassert() in ravb_probe() and take proper action.
I'd also mention moving of the free_netdev() call...
> Fixes: 0d13a1a464a0 ("ravb: Add reset support") > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
| |