Messages in this thread | | | Date | Tue, 28 Nov 2023 09:19:21 +0200 | Subject | Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert() | From | claudiu beznea <> |
| |
On 27.11.2023 18:39, Sergey Shtylyov wrote: > On 11/27/23 12:04 PM, Claudiu wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> reset_control_deassert() could return an error. Some devices cannot work >> if reset signal de-assert operation fails. > > Well, I think all devices can't work if the reset line is connected at all. :-)
I was thinking at the fact that the de-assert support was added just 2 years ago, while the driver seems to be ~8 years old.
> >> To avoid this check the return >> code of reset_control_deassert() in ravb_probe() and take proper action. > > I'd also mention moving of the free_nedev() call...
ok
> >> Fixes: 0d13a1a464a0 ("ravb: Add reset support") >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > [...] > > MBR, Sergey
| |