Messages in this thread | | | Date | Tue, 31 Oct 2023 18:12:01 +0100 | Subject | Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support | From | Krzysztof Kozlowski <> |
| |
On 31/10/2023 13:03, Md Sadre Alam wrote: > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> > Signed-off-by: Sricharan R <quic_srichara@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 5f83ee42a719..b44acb1fac74 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -336,6 +336,11 @@ sdhc_1: mmc@7804000 { > status = "disabled"; > }; > > + bch: qpic_ecc { > + compatible = "qcom,ipq9574-ecc";
NAK. There are so many wrong things with it... Let's start with missing checkpatch. Then with unndeeded label. Then with not allowed underscores in node names. Finally: > + status = "ok";
Drop.
Best regards, Krzysztof
| |