Messages in this thread | | | Date | Fri, 3 Nov 2023 16:56:17 +0530 | Subject | Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support | From | Md Sadre Alam <> |
| |
On 10/31/2023 8:53 PM, Konrad Dybcio wrote: > On 31.10.2023 13:03, Md Sadre Alam wrote: >> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> >> Signed-off-by: Sricharan R <quic_srichara@quicinc.com> >> --- > Hello, > > you're missing: > > - dt-bindings (make dtbs_check is unhappy) > - a commit message > - Co-developed-by for Sricharan
> > status should read "okay" instead, but in this case it's unnecessary > as you're defining the node and lack of the status property also means > that device is enabled > > however > > this ECC engine seems to be a part of the NAND controller, so it's > unlikely that the DT maintainers will agree for it to have a separate > node >
Will drop this patch as this was NAK-ed QPIC controller has the ecc pipelined so will keep the ecc support inlined in both raw nand and serial nand driver.
Regards Alam.
| |