lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support
    From
    On 31.10.2023 13:03, Md Sadre Alam wrote:
    > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
    > Signed-off-by: Sricharan R <quic_srichara@quicinc.com>
    > ---
    Hello,

    you're missing:

    - dt-bindings (make dtbs_check is unhappy)
    - a commit message
    - Co-developed-by for Sricharan


    status should read "okay" instead, but in this case it's unnecessary
    as you're defining the node and lack of the status property also means
    that device is enabled

    however

    this ECC engine seems to be a part of the NAND controller, so it's
    unlikely that the DT maintainers will agree for it to have a separate
    node

    Konrad
    > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
    > index 5f83ee42a719..b44acb1fac74 100644
    > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
    > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
    > @@ -336,6 +336,11 @@ sdhc_1: mmc@7804000 {
    > status = "disabled";
    > };
    >
    > + bch: qpic_ecc {
    > + compatible = "qcom,ipq9574-ecc";
    > + status = "ok";
    > + }
    > +
    > blsp_dma: dma-controller@7884000 {
    > compatible = "qcom,bam-v1.7.0";
    > reg = <0x07884000 0x2b000>;

    \
     
     \ /
      Last update: 2023-10-31 16:24    [W:3.337 / U:1.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site