lkml.org 
[lkml]   [2023]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()
Date


Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Introduce backlight_get_brightness() to simplify logic
> and avoid direct access to backlight properties.

When I read 'introduce' I understand that you are adding a new function.

In fact backlight_get_brightness() already exists, so maybe replace
'introduce' by 'use'


>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Jason Yan <yanaijie@huawei.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/aty/atyfb_base.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
> index 0ccf5d401ecb..ca361e215904 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -2219,13 +2219,7 @@ static int aty_bl_update_status(struct backlight_device *bd)
> {
> struct atyfb_par *par = bl_get_data(bd);
> unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
> - int level;
> -
> - if (bd->props.power != FB_BLANK_UNBLANK ||
> - bd->props.fb_blank != FB_BLANK_UNBLANK)
> - level = 0;
> - else
> - level = bd->props.brightness;
> + int level = backlight_get_brightness(bd);
>
> reg |= (BLMOD_EN | BIASMOD_EN);
> if (level > 0) {
>
> --
> 2.34.1
\
 
 \ /
  Last update: 2023-03-26 23:33    [W:0.331 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site