| Date | Mon, 9 Jan 2023 13:13:00 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank() |
| |
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg <sam@ravnborg.org> > > Avoiding direct access to backlight_properties.props. > > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only used for debug.
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Stephen Kitt <steve@sk2.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-fbdev@vger.kernel.org
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl can generate it and git send-email can utilize the script output...
...
> - write_reg(par, 0xB5, on ? 0x03 : 0x02); > + write_reg(par, 0xB5, !blank ? 0x03 : 0x02);
Why not positive conditional?
write_reg(par, 0xB5, blank ? 0x02 : 0x03);
-- With Best Regards, Andy Shevchenko
|