| Date | Mon, 9 Jan 2023 11:02:59 +0000 | From | Daniel Thompson <> | Subject | Re: [PATCH 13/15] backlight: omap1: Use backlight helpers |
| |
On Sat, Jan 07, 2023 at 07:26:27PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg <sam@ravnborg.org> > > Rework backlight handling to avoid access to the deprecated > backlight_properties.fb_blank member. > > The rework includes removal of get_brightness() operation, > because there was no read back from HW so no use for it. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Jingoo Han <jingoohan1@gmail.com>
This rework will result in additional calls to omapbl_send_enable() during updates so, if anyone who cares about omap1, is filtering LKML then a Tested-by: would be nice.
However, I doubt the additional calls will do any harm so even with that absent: Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
|