lkml.org 
[lkml]   [2023]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()
    From: Sam Ravnborg <sam@ravnborg.org>

    Avoiding direct access to backlight_properties.props.

    Access to the deprecated props.fb_blank replaced by backlight_is_blank().
    Access to props.power is dropped - it was only used for debug.

    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: Stephen Kitt <steve@sk2.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Daniel Thompson <daniel.thompson@linaro.org>
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Cc: linux-fbdev@vger.kernel.org
    ---
    drivers/staging/fbtft/fb_ssd1351.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
    index b8d55aa8c5c7..995fbd2f3dc6 100644
    --- a/drivers/staging/fbtft/fb_ssd1351.c
    +++ b/drivers/staging/fbtft/fb_ssd1351.c
    @@ -190,15 +190,12 @@ static struct fbtft_display display = {
    static int update_onboard_backlight(struct backlight_device *bd)
    {
    struct fbtft_par *par = bl_get_data(bd);
    - bool on;
    + bool blank = backlight_is_blank(bd);

    - fbtft_par_dbg(DEBUG_BACKLIGHT, par,
    - "%s: power=%d, fb_blank=%d\n",
    - __func__, bd->props.power, bd->props.fb_blank);
    + fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: blank=%d\n", __func__, blank);

    - on = !backlight_is_blank(bd);
    /* Onboard backlight connected to GPIO0 on SSD1351, GPIO1 unused */
    - write_reg(par, 0xB5, on ? 0x03 : 0x02);
    + write_reg(par, 0xB5, !blank ? 0x03 : 0x02);

    return 0;
    }
    --
    2.34.1

    \
     
     \ /
      Last update: 2023-03-26 23:31    [W:4.848 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site