Messages in this thread |  | | From | Anup Patel <> | Date | Sat, 28 Jan 2023 20:22:31 +0530 | Subject | Re: [PATCH v3 05/14] RISC-V: KVM: Return correct code for hsm stop function |
| |
On Fri, Jan 27, 2023 at 11:56 PM Atish Patra <atishp@rivosinc.com> wrote: > > According to the SBI specification, the stop function can only > return error code SBI_ERR_FAILED. However, currently it returns > -EINVAL which will be mapped SBI_ERR_INVALID_PARAM. > > Return an linux error code that maps to SBI_ERR_FAILED i.e doesn't map > to any other SBI error code. While EACCES is not the best error code > to describe the situation, it is close enough and will be replaced > with SBI error codes directly anyways. > > Signed-off-by: Atish Patra <atishp@rivosinc.com>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards, Anup
> --- > arch/riscv/kvm/vcpu_sbi_hsm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kvm/vcpu_sbi_hsm.c b/arch/riscv/kvm/vcpu_sbi_hsm.c > index 2e915ca..619ac0f 100644 > --- a/arch/riscv/kvm/vcpu_sbi_hsm.c > +++ b/arch/riscv/kvm/vcpu_sbi_hsm.c > @@ -42,7 +42,7 @@ static int kvm_sbi_hsm_vcpu_start(struct kvm_vcpu *vcpu) > static int kvm_sbi_hsm_vcpu_stop(struct kvm_vcpu *vcpu) > { > if (vcpu->arch.power_off) > - return -EINVAL; > + return -EACCES; > > kvm_riscv_vcpu_power_off(vcpu); > > -- > 2.25.1 >
|  |