lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch v1 01/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234
From


On 22/12/22 00:50, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.12.2022 19:02, Sumit Gupta пишет:
>> +static int tegra_emc_icc_set_bw(struct icc_node *src, struct icc_node *dst)
>> +{
>> + struct tegra186_emc *emc = to_tegra186_emc(dst->provider);
>> + struct tegra_mc *mc = dev_get_drvdata(emc->dev->parent);
>> + struct mrq_bwmgr_int_request bwmgr_req = { 0 };
>> + struct mrq_bwmgr_int_response bwmgr_resp = { 0 };
>> + struct tegra_icc_node *tnode = mc->curr_tnode;
>> + struct tegra_bpmp_message msg;
>> + int ret = 0;
>> +
>> + /*
>> + * Same Src and Dst node will happen during boot from icc_node_add().
>> + * This can be used to pre-initialize and set bandwidth for all clients
>> + * before their drivers are loaded. We are skipping this case as for us,
>> + * the pre-initialization already happened in Bootloader(MB2) and BPMP-FW.
>> + */
>> + if (src->id == dst->id)
>> + return 0;
>> +
>> + if (mc->curr_tnode->type == TEGRA_ICC_NISO)
>
> The mc->curr_tnode usage looks suspicious, why you can't use src node?
>

Now, we can get rid of "curr_tnode" after moving the code from the EMC
to MC driver for transferring MC client's request info to the BPMP.

\
 
 \ /
  Last update: 2023-03-26 23:39    [W:0.965 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site