lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch v1 01/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234
From


On 20/12/22 23:36, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.12.2022 19:02, Sumit Gupta пишет:
>> + if (tegra_bpmp_mrq_is_supported(emc->bpmp, MRQ_BWMGR_INT)) {
>> + err = tegra_emc_interconnect_init(emc);
>> + if (!err)
>> + return err;
>
> "return err" doesn't sound good
>
>> + dev_err(&pdev->dev, "tegra_emc_interconnect_init failed:%d\n", err);
>> + goto put_bpmp;
>
> Move error message to tegra_emc_interconnect_init()
Ok, will change.

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.184 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site