Messages in this thread | | | Date | Wed, 21 Dec 2022 13:35:03 +0530 | Subject | Re: [Patch v1 01/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234 | From | Sumit Gupta <> |
| |
On 20/12/22 23:37, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 20.12.2022 19:02, Sumit Gupta пишет: >> +#ifndef MEMORY_TEGRA_ICC_H >> +#define MEMORY_TEGRA_ICC_H >> + >> +enum tegra_icc_client_type { >> + TEGRA_ICC_NONE, >> + TEGRA_ICC_NISO, >> + TEGRA_ICC_ISO_DISPLAY, >> + TEGRA_ICC_ISO_VI, >> + TEGRA_ICC_ISO_AUDIO, >> + TEGRA_ICC_ISO_VIFAL, >> +}; > > You using only TEGRA_ICC_NISO and !TEGRA_ICC_NISO in the code. > > include/soc/tegra/mc.h defines TAG_DEFAULT/ISO, please drop all these > duplicated and unused "types" unless there is a good reason to keep them >
These type are used while defining clients in "tegra234_mc_clients[]" and its passed to BPMP-FW which has handling for each client type.
kernel$ grep -B2 ".type = TEGRA_ICC_ISO" drivers/memory/tegra/tegra234.c .name = "hdar", .bpmp_id = TEGRA_ICC_BPMP_HDA, .type = TEGRA_ICC_ISO_AUDIO, -- .name = "hdaw", .bpmp_id = TEGRA_ICC_BPMP_HDA, .type = TEGRA_ICC_ISO_AUDIO, -- .name = "vi2w", .bpmp_id = TEGRA_ICC_BPMP_VI2, .type = TEGRA_ICC_ISO_VI, -- .name = "vi2falr", .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, .type = TEGRA_ICC_ISO_VIFAL, -- .name = "vi2falw", .bpmp_id = TEGRA_ICC_BPMP_VI2FAL, .type = TEGRA_ICC_ISO_VIFAL, -- .name = "aper", .bpmp_id = TEGRA_ICC_BPMP_APE, .type = TEGRA_ICC_ISO_AUDIO, -- .name = "apew", .bpmp_id = TEGRA_ICC_BPMP_APE, .type = TEGRA_ICC_ISO_AUDIO, -- .name = "nvdisplayr", .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, .type = TEGRA_ICC_ISO_DISPLAY, -- .name = "nvdisplayr1", .bpmp_id = TEGRA_ICC_BPMP_DISPLAY, .type = TEGRA_ICC_ISO_DISPLAY, -- .name = "apedmar", .bpmp_id = TEGRA_ICC_BPMP_APEDMA, .type = TEGRA_ICC_ISO_AUDIO, -- .name = "apedmaw", .bpmp_id = TEGRA_ICC_BPMP_APEDMA, .type = TEGRA_ICC_ISO_AUDIO,
| |