Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 10 Jan 2023 13:35:31 +0100 | Subject | Re: [PATCH 3/6] driver core: make subsys_dev_iter_init() static |
| |
On Mon, Jan 9, 2023 at 6:58 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > No one outside of drivers/base/bus.c calls this function so make it > static and remove the exported symbol. > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
> --- > drivers/base/bus.c | 5 ++--- > include/linux/device/bus.h | 4 ---- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 45aa8d996f0a..a375305a11dd 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -953,8 +953,8 @@ EXPORT_SYMBOL_GPL(bus_sort_breadthfirst); > * otherwise if it is NULL, the iteration starts at the beginning of > * the list. > */ > -void subsys_dev_iter_init(struct subsys_dev_iter *iter, struct bus_type *subsys, > - struct device *start, const struct device_type *type) > +static void subsys_dev_iter_init(struct subsys_dev_iter *iter, struct bus_type *subsys, > + struct device *start, const struct device_type *type) > { > struct klist_node *start_knode = NULL; > > @@ -963,7 +963,6 @@ void subsys_dev_iter_init(struct subsys_dev_iter *iter, struct bus_type *subsys, > klist_iter_init_node(&subsys->p->klist_devices, &iter->ki, start_knode); > iter->type = type; > } > -EXPORT_SYMBOL_GPL(subsys_dev_iter_init); > > /** > * subsys_dev_iter_next - iterate to the next device > diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h > index d865440d8c02..a1da2f8647af 100644 > --- a/include/linux/device/bus.h > +++ b/include/linux/device/bus.h > @@ -154,10 +154,6 @@ struct subsys_dev_iter { > struct klist_iter ki; > const struct device_type *type; > }; > -void subsys_dev_iter_init(struct subsys_dev_iter *iter, > - struct bus_type *subsys, > - struct device *start, > - const struct device_type *type); > struct device *subsys_dev_iter_next(struct subsys_dev_iter *iter); > void subsys_dev_iter_exit(struct subsys_dev_iter *iter); > > -- > 2.39.0 >
| |