Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 10 Jan 2023 13:34:54 +0100 | Subject | Re: [PATCH 2/6] driver core: remove subsys_find_device_by_id() |
| |
On Mon, Jan 9, 2023 at 6:58 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > This function has not been called by any code in the kernel tree in many > many years so remove it as it is unused. > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
> --- > drivers/base/bus.c | 41 -------------------------------------- > include/linux/device/bus.h | 2 -- > 2 files changed, 43 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 4e6fdb65a157..45aa8d996f0a 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -363,47 +363,6 @@ struct device *bus_find_device(struct bus_type *bus, > } > EXPORT_SYMBOL_GPL(bus_find_device); > > -/** > - * subsys_find_device_by_id - find a device with a specific enumeration number > - * @subsys: subsystem > - * @id: index 'id' in struct device > - * @hint: device to check first > - * > - * Check the hint's next object and if it is a match return it directly, > - * otherwise, fall back to a full list search. Either way a reference for > - * the returned object is taken. > - */ > -struct device *subsys_find_device_by_id(struct bus_type *subsys, unsigned int id, > - struct device *hint) > -{ > - struct klist_iter i; > - struct device *dev; > - > - if (!subsys) > - return NULL; > - > - if (hint) { > - klist_iter_init_node(&subsys->p->klist_devices, &i, &hint->p->knode_bus); > - dev = next_device(&i); > - if (dev && dev->id == id && get_device(dev)) { > - klist_iter_exit(&i); > - return dev; > - } > - klist_iter_exit(&i); > - } > - > - klist_iter_init_node(&subsys->p->klist_devices, &i, NULL); > - while ((dev = next_device(&i))) { > - if (dev->id == id && get_device(dev)) { > - klist_iter_exit(&i); > - return dev; > - } > - } > - klist_iter_exit(&i); > - return NULL; > -} > -EXPORT_SYMBOL_GPL(subsys_find_device_by_id); > - > static struct device_driver *next_driver(struct klist_iter *i) > { > struct klist_node *n = klist_next(i); > diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h > index 0699b3970344..d865440d8c02 100644 > --- a/include/linux/device/bus.h > +++ b/include/linux/device/bus.h > @@ -250,8 +250,6 @@ bus_find_device_by_acpi_dev(struct bus_type *bus, const void *adev) > } > #endif > > -struct device *subsys_find_device_by_id(struct bus_type *bus, unsigned int id, > - struct device *hint); > int bus_for_each_drv(struct bus_type *bus, struct device_driver *start, > void *data, int (*fn)(struct device_driver *, void *)); > void bus_sort_breadthfirst(struct bus_type *bus, > -- > 2.39.0 >
| |