Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 10 Jan 2023 13:33:48 +0100 | Subject | Re: [PATCH 1/6] driver core: make bus_get_device_klist() static |
| |
On Mon, Jan 9, 2023 at 6:58 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > No one calls this function outside of drivers/base/bus.c so make it > static so it does not need to be exported anymore. > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
> --- > drivers/base/bus.c | 3 +-- > include/linux/device/bus.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index e1bf741063e0..4e6fdb65a157 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -927,11 +927,10 @@ struct kset *bus_get_kset(struct bus_type *bus) > } > EXPORT_SYMBOL_GPL(bus_get_kset); > > -struct klist *bus_get_device_klist(struct bus_type *bus) > +static struct klist *bus_get_device_klist(struct bus_type *bus) > { > return &bus->p->klist_devices; > } > -EXPORT_SYMBOL_GPL(bus_get_device_klist); > > /* > * Yes, this forcibly breaks the klist abstraction temporarily. It > diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h > index f2cf7c4ddd20..0699b3970344 100644 > --- a/include/linux/device/bus.h > +++ b/include/linux/device/bus.h > @@ -287,6 +287,5 @@ extern int bus_unregister_notifier(struct bus_type *bus, > #define BUS_NOTIFY_DRIVER_NOT_BOUND 0x00000008 /* driver fails to be bound */ > > extern struct kset *bus_get_kset(struct bus_type *bus); > -extern struct klist *bus_get_device_klist(struct bus_type *bus); > > #endif > -- > 2.39.0 >
| |