Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 10 Jan 2023 13:37:14 +0100 | Subject | Re: [PATCH 6/6] driver core: move struct subsys_dev_iter to a local file |
| |
On Mon, Jan 9, 2023 at 6:58 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > struct subsys_dev_iter is not used by any code outside of > drivers/base/bus.c so move it into that file and out of the global bus.h > file. > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
> --- > drivers/base/bus.c | 5 +++++ > include/linux/device/bus.h | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index e0fe07872a74..e0953656d5ac 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -941,6 +941,11 @@ void bus_sort_breadthfirst(struct bus_type *bus, > } > EXPORT_SYMBOL_GPL(bus_sort_breadthfirst); > > +struct subsys_dev_iter { > + struct klist_iter ki; > + const struct device_type *type; > +}; > + > /** > * subsys_dev_iter_init - initialize subsys device iterator > * @iter: subsys iterator to initialize > diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h > index ffa562f2d975..53e3cdf18bae 100644 > --- a/include/linux/device/bus.h > +++ b/include/linux/device/bus.h > @@ -150,11 +150,6 @@ int device_match_acpi_handle(struct device *dev, const void *handle); > int device_match_any(struct device *dev, const void *unused); > > /* iterator helpers for buses */ > -struct subsys_dev_iter { > - struct klist_iter ki; > - const struct device_type *type; > -}; > - > int bus_for_each_dev(struct bus_type *bus, struct device *start, void *data, > int (*fn)(struct device *dev, void *data)); > struct device *bus_find_device(struct bus_type *bus, struct device *start, > -- > 2.39.0 >
| |