Messages in this thread | | | Date | Wed, 10 Aug 2022 10:34:46 +0200 | Subject | Re: [PATCH v5 00/33] New thermal OF code | From | Daniel Lezcano <> |
| |
Hi Guenter,
On 08/08/2022 12:26, Guenter Roeck wrote: > On Mon, Aug 08, 2022 at 11:42:16AM +0200, Michael Walle wrote:
[ ... ]
> It would also mean that all hwmon drivers registering a thermal zone sensor > would fail to register unless such a thermal zone actually exists. This > would make the whole concept of having the hwmon core register thermal > zone sensors impossible. I have no idea how this is expected to work now, > but there is an apparent flaw in the logic. That means I withdraw my > Acked-by: for the hwmon patches in this series until it is guaranteed > that hwmon registration does not fail as above if there is no thermal > zone associated with a sensor.
I tried to figure out where we are not in sync and I suspect there is a misunderstanding from my side of your initial statement.
I understood you meant the thermal zone can not be created with the hwmon if there is no thermal zone description and that was the case before.
But actually, I suspect I misunderstood and you meant if the thermal OF registration fails, the hwmon creation fails for the hwmon subsystem, and before the changes it was created anyway.
Is that correct ?
If yes, the change -EINVAL --> -ENODEV fixes the issue, shall I consider in this case your Acked-by ?
Thanks -- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |