Messages in this thread | | | Date | Mon, 1 Aug 2022 17:45:07 +0200 | Subject | Re: [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml | From | Krzysztof Kozlowski <> |
| |
On 31/07/2022 00:46, Lukas Wunner wrote: > On Wed, Jul 27, 2022 at 06:46:36PM +0200, Krzysztof Kozlowski wrote: >> 78 files changed, 324 insertions(+), 249 deletions(-) > > Pardon me for being dense, but what is the benefit of this series > that justifies inflating the schema definitions by a total of 75 lines?
The commits were explaining rationale, so let me bring it here. The benefits are: This allows using all properties typical for SPI-connected devices, even these which device bindings author did not tried yet.
Also, what I did not mention in commit msg, this makes sure, that spi-xxx properties have a type, which is validated by spi-peripheral-props.yaml. Otherwise, when someone puts bogus data as spi-max-frequency (e.g. phandle) and checks only with that device schema, no errors are reported.
Best regards, Krzysztof
| |