lkml.org 
[lkml]   [2022]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/10] dt-bindings: iio: dac: use spi-peripheral-props.yaml
    On Wed, Jul 27, 2022 at 06:46:40PM +0200, Krzysztof Kozlowski wrote:
    > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
    > index b0157050f1ee..201b04af2b22 100644
    > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
    > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
    > @@ -33,21 +33,22 @@ properties:
    > vref-supply:
    > description: Needed to provide output scaling.
    >
    > - spi-max-frequency: true
    > -
    > required:
    > - compatible
    > - reg
    > - vref-supply
    >
    > -additionalProperties: false
    > -
    > oneOf:
    > - required:
    > - spi-cpha
    > - required:
    > - spi-cpol
    >
    > +allOf:
    > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
    > +
    > +unevaluatedProperties: false
    > +
    > examples:
    > - |
    > vref_2v5_reg: regulator-vref {

    Just to double-check because I'm unsure how the allOf interacts with
    the oneOf above: The DT must specify either spi-cpha or spi-cpol
    for this device, but not both. Hopefully that's still enforced
    after your change?

    Thanks,

    Lukas

    \
     
     \ /
      Last update: 2022-07-31 00:44    [W:4.700 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site