Messages in this thread | | | Date | Wed, 3 Aug 2022 15:29:26 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v2 02/10] dt-bindings: iio: accel: use spi-peripheral-props.yaml |
| |
On Sun, Jul 31, 2022 at 04:49:43PM +0100, Jonathan Cameron wrote: > On Wed, 27 Jul 2022 18:46:38 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > Instead of listing directly properties typical for SPI peripherals, > > reference the spi-peripheral-props.yaml schema. This allows using all > > properties typical for SPI-connected devices, even these which device > > bindings author did not tried yet. > > > > Remove the spi-* properties which now come via spi-peripheral-props.yaml > > schema, except for the cases when device schema adds some constraints > > like maximum frequency. > > > > While changing additionalProperties->unevaluatedProperties, put it in > > typical place, just before example DTS. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > I wonder if spi-3wire is device specific (not controller) and should be > > rather explicitly mentioned by device schema. Just like spi-cpol/cpha. > > I think it is, but Mark is expert on this.
I would say yes as it's the device with a single data line.
> In general I'm waiting on Mark's opinion on the whole idea!
The prerequisite changes (except for spi-3-wire) are already queued up by Mark as are changes for other subsystems.
Rob
| |