Messages in this thread |  | | Date | Mon, 4 Jul 2022 08:35:52 +0100 | Subject | Re: [PATCH v3 05/12] thermal/core: Remove unneeded EXPORT_SYMBOLS | From | Lukasz Luba <> |
| |
Hi Daniel,
(+Todd and Wei on CC)
On 7/3/22 19:30, Daniel Lezcano wrote: > Different functions are exporting the symbols but are actually only > used by the thermal framework internals. Remove these EXPORT_SYMBOLS. > > Cc: Alexandre Bailon <abailon@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc; Eduardo Valentin <eduval@amazon.com> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> > --- > drivers/thermal/thermal_helpers.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c > index 3edd047e144f..f4c1e87ef040 100644 > --- a/drivers/thermal/thermal_helpers.c > +++ b/drivers/thermal/thermal_helpers.c > @@ -39,7 +39,6 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip) > > return trend; > } > -EXPORT_SYMBOL(get_tz_trend); > > struct thermal_instance * > get_thermal_instance(struct thermal_zone_device *tz, > @@ -228,7 +227,6 @@ void thermal_cdev_update(struct thermal_cooling_device *cdev) > } > mutex_unlock(&cdev->lock); > } > -EXPORT_SYMBOL(thermal_cdev_update);
I wouldn't remove that export. I can see in my Pixel6 modules dir, that it's called in 7 places.
I assume that in Android world this is common use.
Regards, Lukasz
|  |