Messages in this thread |  | | From | "Rafael J. Wysocki" <> | Date | Tue, 5 Jul 2022 15:59:48 +0200 | Subject | Re: [PATCH v3 09/12] thermal/core: Register with the trip points |
| |
On Tue, Jul 5, 2022 at 4:03 AM Zhang Rui <rui.zhang@intel.com> wrote: > > On Sun, 2022-07-03 at 20:30 +0200, Daniel Lezcano wrote: > > As we added the thermal trip points structure in the thermal zone, > > let's extend the thermal zone register function to have the thermal > > trip structures as a parameter and store it in the 'trips' field of > > the thermal zone structure. > > Just FYI. > > I proposed a small topic for this year' LPC about the > thermal_zone_device_register() parameters. > We have more and more parameters introduced, IMO, it's better to use a > unified structure for registration phase configurations, or reuse > struct thermal_zone_params. > In this way, when a new parameter is needed, we only need to introduce > a new field in the structure, rather than update every caller of this > API, or introduce new wrapper functions like we did in this patch.
Sounds reasonable to me.
|  |