lkml.org 
[lkml]   [2022]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 01/12] thermal/core: Remove duplicate information when an error occurs
    Date
    The pr_err already tells it is an error, it is pointless to add the
    'Error:' string in the messages. Remove them.

    Cc: Alexandre Bailon <abailon@baylibre.com>
    Cc: Kevin Hilman <khilman@baylibre.com>
    Cc; Eduardo Valentin <eduval@amazon.com>
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org>
    ---
    drivers/thermal/thermal_core.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
    index cdc0552e8c42..e22e7d939c54 100644
    --- a/drivers/thermal/thermal_core.c
    +++ b/drivers/thermal/thermal_core.c
    @@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask,
    struct thermal_governor *governor;

    if (!type || strlen(type) == 0) {
    - pr_err("Error: No thermal zone type defined\n");
    + pr_err("No thermal zone type defined\n");
    return ERR_PTR(-EINVAL);
    }

    if (type && strlen(type) >= THERMAL_NAME_LENGTH) {
    - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n",
    + pr_err("Thermal zone name (%s) too long, should be under %d chars\n",
    type, THERMAL_NAME_LENGTH);
    return ERR_PTR(-EINVAL);
    }

    if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) {
    - pr_err("Error: Incorrect number of thermal trips\n");
    + pr_err("Incorrect number of thermal trips\n");
    return ERR_PTR(-EINVAL);
    }

    if (!ops) {
    - pr_err("Error: Thermal zone device ops not defined\n");
    + pr_err("Thermal zone device ops not defined\n");
    return ERR_PTR(-EINVAL);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-07-03 20:32    [W:4.261 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site