Messages in this thread |  | | Date | Mon, 4 Jul 2022 09:01:42 +0100 | Subject | Re: [PATCH v3 03/12] thermal/of: Remove the device node pointer for thermal_trip | From | Lukasz Luba <> |
| |
On 7/3/22 19:30, Daniel Lezcano wrote: > The device node pointer is no longer needed in the thermal trip > structure, remove it. > > Cc: Alexandre Bailon <abailon@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc; Eduardo Valentin <eduval@amazon.com> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> > --- > drivers/thermal/thermal_core.h | 2 -- > drivers/thermal/thermal_of.c | 8 -------- > 2 files changed, 10 deletions(-) > > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index 726e327b4205..ff10cdda056c 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -70,13 +70,11 @@ void __thermal_cdev_update(struct thermal_cooling_device *cdev); > > /** > * struct thermal_trip - representation of a point in temperature domain > - * @np: pointer to struct device_node that this trip point was created from > * @temperature: temperature value in miliCelsius > * @hysteresis: relative hysteresis in miliCelsius > * @type: trip point type > */ > struct thermal_trip { > - struct device_node *np; > int temperature; > int hysteresis; > enum thermal_trip_type type; > diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c > index 04c910ca8623..16eb18c24430 100644 > --- a/drivers/thermal/thermal_of.c > +++ b/drivers/thermal/thermal_of.c > @@ -867,10 +867,6 @@ static int thermal_of_populate_trip(struct device_node *np, > return ret; > } > > - /* Required for cooling map matching */ > - trip->np = np; > - of_node_get(np); > - > return 0; > } > > @@ -1000,8 +996,6 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) > > kfree(tz->tbps); > free_trips: > - for (i = 0; i < tz->ntrips; i++) > - of_node_put(tz->trips[i].np); > kfree(tz->trips); > of_node_put(gchild); > free_tz: > @@ -1026,8 +1020,6 @@ static __init void of_thermal_free_zone(struct __thermal_zone *tz) > } > > kfree(tz->tbps); > - for (i = 0; i < tz->ntrips; i++) > - of_node_put(tz->trips[i].np); > kfree(tz->trips); > kfree(tz); > }
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
|  |